CP-22444: CloudZero KSM (Feature Branch) #102
Conversation
… subchart (#91) * override KSM name * enable ksm by default * make cloudzero ksm undiscoverable * improve documentation * option 2 is not the default behavior * fix indentation * add line * add documentation for changing the service port for cloudzero ksm * disable cloudzero KSM as scrape target * set default port * fix endpoint * use default port * add release notes * remove metric exporter documentation * change beta version
bdrennz
had a problem deploying
to
release-notes
GitHub Actions
Failure
|
You want to have this as a PR going to the |
This is just a placeholder PR for when we eventually merge the changes. That's why it's a "Draft". |
* change kube-state-metrics value name to avoid template errors * define static target * fix kube-state-metrics dependency * remove unused documentation * cast port to int * fix endpoint * update scrape config * dynamicaly populate metrics * use camel case
bdrennz
had a problem deploying
to
release-notes
GitHub Actions
Failure
| @@ -45,7 +45,7 @@ helm install <RELEASE_NAME> cloudzero-beta/cloudzero-agent \ | |||
| --set clusterName=<CLUSTER_NAME> \ | |||
| --set-string cloudAccountId=<CLOUD_ACCOUNT_ID> \ | |||
| --set region=<REGION> \ | |||
| --set kube-state-metrics.enabled=<true|false> \ | |||
| --set kube_state_metrics.enabled=<true|false> \ | |||
There was a problem hiding this comment.
do we want to remove this? I would think that we wouldn't want to show this option now?
| @@ -47,10 +47,18 @@ prometheusConfig: | |||
| # -- Any items added to this list will be added to the Prometheus scrape configuration. | |||
| additionalScrapeJobs: [] | |||
|
|
|||
| kube-state-metrics: | |||
| enabled: false | |||
| kubeStateMetrics: | |||
There was a problem hiding this comment.
does this work if alias is not set in the dependencies section? I would have thought that would need to be set. but maybe I'm just not up to date
| follow_redirects: true | ||
| enable_http2: true | ||
| - separator: ; | ||
| regex: ^(board_asset_tag|container|created_by_kind|created_by_name|image|instance|name|namespace|node|node_kubernetes_io_instance_type|pod|product_name|provider_id|resource|unit|uid|_.*|label_.*|app.kubernetes.io/*|k8s.*)$ |
There was a problem hiding this comment.
might be a good idea to remove the named template that this is replacing if we're not going to use it. I do like this change though, it's more readable for sure
|
also, do you think we should remove this line: https://github.com/Cloudzero/cloudzero-charts/pull/102/files#diff-0217cc97d5b1d9cfdc746b1dcd2d4b88c04fb243e7099a15dc5aaea8d138145eR17 ? just because we're not advertising ksm anymore? |
This PR contains all the CloudZero KSM changes:
Testing:
Beta Release Request:
Checklist
main